asciidoctor / asciidoctor-browser-extension

:white_circle: An extension for web browsers that converts AsciiDoc files to HTML using Asciidoctor.js.
https://chrome.google.com/webstore/detail/asciidoctorjs-live-previe/iaalpfgpbocpdfblpnhhgllgbdbchmia
MIT License
220 stars 50 forks source link

Refresh README.adoc and associated docs #648

Closed sturtison closed 1 year ago

sturtison commented 1 year ago

Could I help you with your plugin by suggesting some changes via a draft PR to refresh the docs?

See draft PR https://github.com/asciidoctor/asciidoctor-browser-extension/pull/649

See latest draft page here: https://github.com/sturtison/asciidoctor-browser-extension/blob/docs/issue-648-refresh-docs-draft/README.adoc

Proposed TOC for the Asciidoctor Browser Extension

Thank you for a great plugin.

Edits: Add link to the draft PR https://github.com/asciidoctor/asciidoctor-browser-extension/pull/649, to the latest page

ggrossetie commented 1 year ago

That's sounds great 👍🏻

sturtison commented 1 year ago

This does not provide a walk through like https://github.com/asciidoctor/asciidoctor-browser-extension/issues/528 however it does lead the different reader groups through the install in more detail.

Some adoption road bumps have been:

sturtison commented 1 year ago

Squashed and rebased on main.

sturtison commented 1 year ago
sturtison commented 1 year ago

The URIs for the images will have to be changed if the PR is accepted as they refer to the raw.githubusercontent on the forked branch.

sturtison commented 1 year ago

Looking for the recommended way to show the my.email@example.com in the as-is block.

https://github.com/sturtison/asciidoctor-browser-extension/blob/5f0dd5273a75b0e38b13ac680ac4cfa830a7c5b0/README.adoc#L218-L224

sturtison commented 1 year ago

Looking for the recommended way to show the my.email@example.com in the as-is block.

https://github.com/sturtison/asciidoctor-browser-extension/blob/5f0dd5273a75b0e38b13ac680ac4cfa830a7c5b0/README.adoc#L218-L224

Fixed.

sturtison commented 1 year ago

The URIs for the images will have to be changed if the PR is accepted as they refer to the raw.githubusercontent on the forked branch.

Fixed by @ggrossetie to be:url-asciidoctor-sc-image: https://cdn.jsdelivr.net/gh/asciidoctor/asciidoctor/screenshot.png in features.adoc

mojavelinux commented 1 year ago

Truly excellent work @sturtison and @ggrossetie!

mojavelinux commented 1 year ago

To ensure that docs changes get published right away (instead of nightly), you may be interested in setting up the deploy-docs workflow. See https://github.com/asciidoctor/asciidoctor-pdf/blob/v2.3.x/.github/workflows/deploy-docs.yml for an example. I've already set up the secret for that workflow to use.