search

asciidoctor / asciidoctor-chart

A set of Asciidoctor extensions that add a chart block and block macro to AsciiDoc for including charts in your AsciiDoc document.
Other
29 stars 13 forks source link

resolves #25 add attributes to define chart resources directory #26

Closed uniqueck closed 2 years ago

uniqueck commented 2 years ago

solves #25

ggrossetie commented 2 years ago

Linter is failing, you can run it locally using bundle exec rake lint. You can also check GitHub Action logs to see the errors: https://github.com/asciidoctor/asciidoctor-chart/runs/6241184676?check_suite_focus=true

uniqueck commented 2 years ago

@Mogztter do I have to increment the version? If all is fine, I add the missing documentation in readme.adoc and squash my commits.

ggrossetie commented 2 years ago

do I have to increment the version?

No, it will be done as part of the release process.

uniqueck commented 2 years ago

So i rework the code with you annotations and introduce a new attribute for d3 javascript library.

mojavelinux commented 2 years ago

Seems okay to me now.

ggrossetie commented 2 years ago

@uniqueck Looks good, could you please update the README (as discussed in https://github.com/asciidoctor/asciidoctor-chart/issues/25#issuecomment-1114029172) to explain how to use these new attributes?

uniqueck commented 2 years ago

Sure and I squash my commits to one.

ggrossetie commented 2 years ago

Perfect, thanks 👍🏻