resolves #29 update c3.js defaults to latest version 0.7.20

[uniqueck]

fixes #29

[ggrossetie]

Did you make sure that everything works as expected? It's surprising that there's not a single breaking change?

[uniqueck]

How? Should I use this gem and render some example files and check if this chart looks ok?

[ggrossetie]

Yes, we can add a few examples in this repository to make it easier to test when we upgrade. We could potentially use something like Cypress to automate things but one step at a time 😉

[uniqueck]

How do you generate those example graphics? Do you install this gem and you this to generate these png / svg?

[ggrossetie]

How do you generate those example graphics?

Are you referring to the screenshots in the README? I created an AsciiDoc file, converted it to HTML with this extension enabled and then took screenshots. Technically, we could automate the process using Puppeteer but I don't know if it's worth it.

[uniqueck]

My question was more aimed at how to use my local packaged Ruby Gem to generate these previews?

[ggrossetie]

I believe the easiest way is to require lib/asciidoctor-chart.rb from your local copy:

asciidoctor -r ./lib/asciidoctor-chart.rb doc.adoc

[uniqueck]

Do you know a way to call npm from bundle exec? I would like to use cypress for visual regression tests and the cypress gem for ruby is for rails.

[ggrossetie]

I don't mind adding a package.json (since we want to transpile this extension to JavaScript). You can call npm directly and use Cypress from Node.

[ggrossetie]

However, please create a dedicated issue and pull request to introduce this change.

[uniqueck]

However, please create a dedicated issue and pull request to introduce this change.

Yes that was my plan, but i would like to try it and investigate for a solution, to check if all is fine after upgrade to latest version of c3.js.

[uniqueck]

I created another issue #33 for that, i think it is a good idea to wait with this change for a solution of #33.

[uniqueck]

Should rebased and merged after #34.

[ggrossetie]

The rendering slightly changed but it's barely noticeable:

After

Margin between 0 and 1 at the bottom is thinner and the graph is slightly wider.

Before

[ggrossetie]

Rebased on master and base image for C3.js updated