resolves #33 introduce visual regression tests

asciidoctor / asciidoctor-chart

A set of Asciidoctor extensions that add a chart block and block macro to AsciiDoc for including charts in your AsciiDoc document.

Other

29 stars 13 forks source link

resolves #33 introduce visual regression tests #34

Closed uniqueck closed 2 years ago

uniqueck commented 2 years ago

@Mogztter I'm back from holiday and started to implement visual regression tests with cypress for generated charts. These feature isn't ready to merge, it's more to start a discussion for how we would like to integrate the visual regression tests in future development process. How would we like to update the golden master screenshots, should we describe this process in a contributing guide, or is it enough to describe it short in README.adoc.

ggrossetie commented 2 years ago

Thank you for taking care of this! I will checkout your branch this week and give it a try 😄

uniqueck commented 2 years ago

Hi @Mogztter, do you have time to check this PR?

ggrossetie commented 2 years ago

@uniqueck I made a few changes and rebased on top of master, it looks good 👍🏻