search

asciidoctor / asciidoctor-chart

A set of Asciidoctor extensions that add a chart block and block macro to AsciiDoc for including charts in your AsciiDoc document.
Other
29 stars 13 forks source link

Added the convert_ prefix in the ChartBlock #42

Closed B3nedikt closed 1 year ago

B3nedikt commented 1 year ago

To be honest I don't completely understand this module system xD But without this change it does not work for me locally. I would fix the tests if you think this is a good change ;)

Does it just take the module name and prefixe it with convert_ ?

ggrossetie commented 1 year ago

But without this change it does not work for me locally.

@B3nedikt could you please open an issue with a simple reproduction case please? Thanks!

Does it just take the module name and prefixe it with convert_ ?

Yes the converter will append convert_. You can see that the tests are failing:

     NoMethodError:
       undefined method `convert_convert_chart' for #<Asciidoctor::Converter::Html5Converter:0x000055dc48cafdd0>
       Did you mean?  convert_chart
ggrossetie commented 1 year ago

It seems that the new converters should use prefixed method names according to this comment:

https://github.com/asciidoctor/asciidoctor/blob/4bab183b9f3fad538f86071b2106f3b8185d3832/lib/asciidoctor/converter/html5.rb#L1347-L1350

So maybe we need to fix something but without a reproduction case I can only guess.