Github actions Windows CI migration

asciidoctor / asciidoctor-diagram

:left_right_arrow: Asciidoctor diagram extension, with support for AsciiToSVG, BlockDiag (BlockDiag, SeqDiag, ActDiag, NwDiag), Ditaa, Erd, GraphViz, Mermaid, Msc, PlantUML, Shaape, SvgBob, Syntrax, UMLet, Vega, Vega-Lite and WaveDrom.

http://asciidoctor.org

MIT License

435 stars 106 forks source link

Github actions Windows CI migration #317

Closed snecklifter closed 3 years ago

snecklifter commented 3 years ago

Raising this to track migration from appveyor/travis to Github Actions for Windows (Linux is working). Have made some progress on the Windows branch and the test suite now runs to completion.

@pepijnve there are 20-odd errors remaining which will probably make more sense to you than me?

https://github.com/asciidoctor/asciidoctor-diagram/runs/1657558579?check_suite_focus=true

pepijnve commented 3 years ago

It took me a while but I finally figured out what was going on. The gem communicates with the Java subprocess via stdin/stdout:

The encoding for these streams was not being set; that's now set to be UTF-8.
Both Ditaa and PlantUML are kind of sloppy when it comes to output. Some codepaths in Ditaa were writing directly to stdout and that was getting interleaved in with the response data. As a quick fix I'm redirecting regular stdout to stderr.

With those two fixes the Windows builds are working and AppVeyor is out of the picture.

snecklifter commented 3 years ago

Excellent news, thanks for the explanation.