asciidoctor / asciidoctor-diagram

:left_right_arrow: Asciidoctor diagram extension, with support for AsciiToSVG, BlockDiag (BlockDiag, SeqDiag, ActDiag, NwDiag), Ditaa, Erd, GraphViz, Mermaid, Msc, PlantUML, Shaape, SvgBob, Syntrax, UMLet, Vega, Vega-Lite and WaveDrom.
http://asciidoctor.org
MIT License
435 stars 106 forks source link

Enable Lilypond test on OS X #325

Closed snecklifter closed 3 years ago

pepijnve commented 3 years ago

I can add more intelligent macOS support for Lilypond tomorrow similar to how the wavedrom editor is handled. The converter looks for the .app and looks for the command in the bundle itself. See https://github.com/asciidoctor/asciidoctor-diagram/blob/master/lib/asciidoctor-diagram/wavedrom/converter.rb#L33 for the details.

It might be nicer to only allow Lilypond itself to be run rather than turning off the entire security assessment system. You should be able to do that using spctl --add <path to app>.

snecklifter commented 3 years ago

Sounds good regarding improved support. Thanks for the spctl tip, testing now.