asciidoctor / asciidoctor-diagram

:left_right_arrow: Asciidoctor diagram extension, with support for AsciiToSVG, BlockDiag (BlockDiag, SeqDiag, ActDiag, NwDiag), Ditaa, Erd, GraphViz, Mermaid, Msc, PlantUML, Shaape, SvgBob, Syntrax, UMLet, Vega, Vega-Lite and WaveDrom.
http://asciidoctor.org
MIT License
432 stars 106 forks source link

Update PlantUML to 1.2022.12 #394

Closed thirtque closed 1 year ago

thirtque commented 1 year ago

Just updating PlantUML to 1.2022.12 as it adds some new features I would like to use.

Used the MIT ASL license version from the download page.

pepijnve commented 1 year ago

I think up until now I've been using the Apache licensed one. Not sure what the functional difference (if any) there is wrt the MIT one. It might be best to stick to that version just to be no the safe side.

thirtque commented 1 year ago

I see that in the LICENSE.txt you use MIT, but probably there is no difference in the binary itself.

Just checked to be sure, and the binaries are in fact different.

sha256sum plantuml-asl.jar plantuml-mit.jar 
970cf1c8cc442a63d3708a0b424d5b6ff531aa49f997478fc2afb97034d6cf35  plantuml-asl.jar
8c41a1d5eb4d270f3183f0fa80210641ce274548e549bdb53549255339f1e076  plantuml-mit.jar
thirtque commented 1 year ago

Ok, just now noticed plantuml-license.txt. Should be ok now.

owbear commented 1 year ago

Anything we can do to get this through? Our pipeline fails with the older plantuml included now:

FIL@0 <-> @80 : (filtering time = 80 ms)                                                                                                         
^^^^^                                                                                                                                            
 You should send a mail to plantuml@gmail.com or post to http://plantuml.com/qa with this log (V1.2022.5) java.lang.UnsupportedOperationException

Due to https://forum.plantuml.net/16197/timing-diagram-adding-double-arrows-to-analog-signal-type fixed in V1.2022.7

pepijnve commented 1 year ago

@owbear if you're blocked on this, there's always the option of using an external plantuml jar instead of the builtin one via the DIAGRAM_PLANTUML_CLASSPATH environment variable.

I'll get this merged and published asap. Nothing was really holding this back except availability of spare time on my end.