search

asciidoctor / asciidoctor-diagram

:left_right_arrow: Asciidoctor diagram extension, with support for AsciiToSVG, BlockDiag (BlockDiag, SeqDiag, ActDiag, NwDiag), Ditaa, Erd, GraphViz, Mermaid, Msc, PlantUML, Shaape, SvgBob, Syntrax, UMLet, Vega, Vega-Lite and WaveDrom.
http://asciidoctor.org
MIT License
431 stars 106 forks source link

Downgrading to PlantUML 1.2023.7 (?) due to problems in the ASL distribution? #444

Closed ahus1 closed 9 months ago

ahus1 commented 9 months ago

A user of the AsciiDoc plugin for IntelliJ found a problem where the OpenIconic icons no longer show. See: https://github.com/asciidoctor/asciidoctor-intellij-plugin/issues/1446

I also found that you reported some problems with Ditaa in https://github.com/plantuml/plantuml/issues/1514

There seems to be some regressions in the latest packaging - with 1.2023.7 being the last version which included at least OpenIconic when downloading it from SourceForge.

So I wonder: Are there plans to downgrade PlantUML for Asciidoctor Diagram? I am a bit undecided for now. I might also only downgrade Asciidoctor Diagram in the AsciiDoc plugin for IntelliJ, even for that I'm not sure.

I'd be happy to hear your thoughts on this.

ahus1 commented 9 months ago

I saw a quite fast response from the PlantUML team. I'll watch how it progresses. If there would be a rollback, I'll for now consider it only for the AsciiDoc plugin for IntelliJ, as those users don't have a choice of which version of Asciidoctor Diagram they choose. Let's see how it evolves.

pepijnve commented 9 months ago

The diagram gem itself doesn't depend on a specific version of PlantUML, so feel free to downgrade it. We could consider yanking the wrapper gem versions higher than 1.2023.7. I agree to wait and see if this gets resolved quickly or not for the time being.

ahus1 commented 9 months ago

Thank you for reminding me that they are independent. Will downgrade PlantUML then for the AsciiDoc plugin, and soon publish a pre-release for the AsciiDoc Plugin for IntelliJ. It will depend on the schedule for a final release of PlantUML if I promote the pre-release to a regular release.

Closing it as your answer resolved my question.

pepijnve commented 8 months ago

@ahus1 I've just published the gem wrapper for PlantUML 1.2023.12 which should resolve this. I've also switched to the LGPL distribution to restore Ditaa through PlantUML.