search

asciidoctor / asciidoctor-diagram

:left_right_arrow: Asciidoctor diagram extension, with support for AsciiToSVG, BlockDiag (BlockDiag, SeqDiag, ActDiag, NwDiag), Ditaa, Erd, GraphViz, Mermaid, Msc, PlantUML, Shaape, SvgBob, Syntrax, UMLet, Vega, Vega-Lite and WaveDrom.
http://asciidoctor.org
MIT License
445 stars 109 forks source link

rexml dependency leads to incompatibility with asciidoctor-pdf #466

Closed oddhack closed 3 months ago

oddhack commented 3 months ago

Updated: Over in the Zulip link below, Dan followed up on the current state of rexml and thinks that this can probably be resolved on the asciidoctor-pdf end with no action here. But that is pending the result of CI builds - so please hold off on any action here for a bit, and hopefully this can be closed. Thanks!

Original issue: Per discussion on Zulip , when I install asciidoctor-pdf (2.3.17) and asciidoctor-diagram (2.3.1) against Ruby 3.3.4 and try to use them both in the same build, I get errors that turn out to be because the pdf gem has a locked dependency on rexml = 2.3.6, while the diagram gem has a dependency on latest rexml and pulls 2.3.8.

@mojavelinux says that they will not unlock the asciidoctor-pdf dependency until some contentious issue about rexml 2.3.7+, which I personally do not understand, is addressed, and advises asciidoctor-diagram also lock itself to rexml 2.3.6. This seems to work well enough here (by manually removing 2.3.8).

oddhack commented 3 months ago

Updated - see original issue description above, but this may turn out to be a non-issue if it can be resolved on the asciidoctor-pdf end.

oddhack commented 3 months ago

Closing, indeed resolved by the asciidoctor-pdf update from yesterday. Sorry for the false alarm