asciidoctor / asciidoctor-diagram

:left_right_arrow: Asciidoctor diagram extension, with support for AsciiToSVG, BlockDiag (BlockDiag, SeqDiag, ActDiag, NwDiag), Ditaa, Erd, GraphViz, Mermaid, Msc, PlantUML, Shaape, SvgBob, Syntrax, UMLet, Vega, Vega-Lite and WaveDrom.
http://asciidoctor.org
MIT License
445 stars 109 forks source link

vega engine table #473

Closed noraj closed 3 weeks ago

noraj commented 3 weeks ago

Currently, https://docs.asciidoctor.org/diagram-extension/latest/diagram_types/vega/ displays like this:

image

mojavelinux commented 3 weeks ago

Something is definitely wrong with that table, to be sure. Thanks for submitting a fix for it.

pepijnve commented 3 weeks ago

Nevermind my earlier comment. I reviewed the PR again and these two rows are indeed describing the required binaries. That information should go under an 'installation' section.

noraj commented 3 weeks ago

@pepijnve Is that better now?

pepijnve commented 3 weeks ago

Perfect. Thanks for spotting the mistake and providing the fix!