search

asciidoctor / asciidoctor-diagram

:left_right_arrow: Asciidoctor diagram extension, with support for AsciiToSVG, BlockDiag (BlockDiag, SeqDiag, ActDiag, NwDiag), Ditaa, Erd, GraphViz, Mermaid, Msc, PlantUML, Shaape, SvgBob, Syntrax, UMLet, Vega, Vega-Lite and WaveDrom.
http://asciidoctor.org
MIT License
439 stars 107 forks source link

ASCIImage support #72

Closed nikolay closed 8 years ago

nikolay commented 9 years ago

It would be nice to have ASCIImage as an extension similar to the diagramming one.

There's a Ruby-based library already: https://github.com/Oblomov/asciimage-ruby

Originally submitted here: https://github.com/asciidoctor/asciidoctor/issues/1317

pepijnve commented 9 years ago

@nikolay given that there's already a Ruby port for this it should be pretty trivial to integrate. I'll try to get this in the next release. Thanks for the suggestion.

nikolay commented 9 years ago

@pepijnve Thank you!

pepijnve commented 9 years ago

I spent some time reviewing this in more detail and it's not as simple as I thought.

From a technical perspective the code you pointed to is a bit hard to reuse. It's not published as a gem, so depending on it that way isn't possible yet. It doesn't have any license on it yet, so I can't just integrate it either. Making my own asciiimage interpreter would be a fun exercise of course :D

From a practical perspective I'm not sure how you would actually use this in an asciidoc document. The more complex icons require code to do the 'hole punching' part since there's no way to define styling in the icon description itself. You could embed some ruby in the asciidoc document of course, but I'm not convinced that would be practical at all.

Could provide an example of how you would want to use this in practice? If there are no technical limits, what would the ideal integration in asciidoc look like?

mojavelinux commented 9 years ago

It's not published as a gem, so depending on it that way isn't possible yet.

I'd say that's definitely a prerequisite.

Could provide an example of how you would want to use this in practice?

I'd really like to see an example as well.

nikolay commented 9 years ago

@pepijnve @mojavelinux Thank you guys! Let me try to address the first issue with the author and will work on an example for you as well!

pepijnve commented 8 years ago

Marked this issue as deferred. While it would be a nifty feature to implement I have my doubts about its usefulness. If anyone feels like contributing a patch for this, those are always welcome of course.

pepijnve commented 8 years ago

Since there's been no news on this and its usefulness seems limited I'm going to close this issue. Feel free to reopen if there are any updates.