search

asciidoctor / asciidoctor-extensions-lab

A lab for testing and demonstrating Asciidoctor extensions. Please do not use this code in production. If you want to use one of these extensions in your application, create a new project, import the code, and distribute it as a RubyGem. You can then request to make it a top-level project under the Asciidoctor organization.
Other
105 stars 101 forks source link

Adds a new inline extension about emoji icons #18

Closed lordofthejars closed 9 years ago

lordofthejars commented 9 years ago

Adds a new inline extension about emoji icons so emoji icons can be used in any AsciiDoc document.

mojavelinux commented 9 years ago

Let me know when it's merge-ready, @lordofthejars & @Mogztter.

lordofthejars commented 9 years ago

This afternoon I will fix the copy paste problem (in fact the extension works :)) and I will ping you. Also I am working on another extension to write tutorials. Maybe you are thinking why I am not developing asciidoctorj instead of these extensions. I have asciidoctorj in mind, in fact I push some code in my private repo, but I need these extensions in my current job :). Stay tunned, more to come :)

2014-11-03 5:41 GMT+01:00 Dan Allen notifications@github.com:

Let me know when it's merge-ready, @lordofthejars https://github.com/lordofthejars & @Mogztter https://github.com/Mogztter.

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-extensions-lab/pull/18#issuecomment-61439943 .

+----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

ggrossetie commented 9 years ago

@lordofthejars What is the steps-postprocessor extension ?

lordofthejars commented 9 years ago

See my latest tweet :)

2014-11-03 20:26 GMT+01:00 Guillaume Grossetie notifications@github.com:

@lordofthejars https://github.com/lordofthejars What is the steps-postprocessor extension ?

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-extensions-lab/pull/18#issuecomment-61533117 .

+----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

ggrossetie commented 9 years ago

Nice you're a CSS ninja ;)

lordofthejars commented 9 years ago

Well not at all, I have found an example and I have modified to the needs hehehe.

2014-11-03 20:29 GMT+01:00 Guillaume Grossetie notifications@github.com:

Nice you're a CSS ninja ;)

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-extensions-lab/pull/18#issuecomment-61533657 .

+----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

mojavelinux commented 9 years ago

I'm going to go ahead and merge, then follow-up with some minor cleanup.

mojavelinux commented 9 years ago

Cleanup complete. As it turns out, extensions don't have to worry about any of the logic of using data-uri. That work can be delegated to AbstractNode so we get consistency with Asciidoctor default behavior.

lordofthejars commented 9 years ago

Dan can you explain me this line https://github.com/asciidoctor/asciidoctor-extensions-lab/blob/master/lib/emoji-inline-macro/extension.rb#L15 I don't understand the parent.image_uri part :)

mojavelinux commented 9 years ago

It's a reference to a built-in function in Asciidoctor that handles all aspects of linking to or embedding an image.

lordofthejars commented 9 years ago

ok :)

2014-11-04 8:45 GMT+01:00 Dan Allen notifications@github.com:

It's a reference to a built-in function in Asciidoctor that handles all aspects of linking to or embedding an image.

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-extensions-lab/pull/18#issuecomment-61603994 .

+----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

ggrossetie commented 9 years ago

Nice :+1: