search

asciidoctor / asciidoctor-extensions-lab

A lab for testing and demonstrating Asciidoctor extensions. Please do not use this code in production. If you want to use one of these extensions in your application, create a new project, import the code, and distribute it as a RubyGem. You can then request to make it a top-level project under the Asciidoctor organization.
Other
105 stars 101 forks source link

adds twemoji integration. #25

Closed lordofthejars closed 9 years ago

mojavelinux commented 9 years ago

Excellent. I'll have a look asap!

ggrossetie commented 9 years ago

Looking forward to see this pull request merged!! @lordofthejars tell me if you need help :smile:

mojavelinux commented 9 years ago

I'd like to see it merged with the other emoji macro so that we don't couple the syntax to the implementation. Make sense?

lordofthejars commented 9 years ago

Yes it has sense but no time :( @Mogztter if you want or can you can try to join both. Moreover it can be refactored to use DocInfoProcessor.

mojavelinux commented 9 years ago

:+1:

ggrossetie commented 9 years ago

@lordofthejars @mojavelinux Ok I will see what I can do :smile:

lordofthejars commented 9 years ago

It should be easyt, only moving both codes into one repo.

ggrossetie commented 9 years ago

I opened a new PR #29 with your code

mojavelinux commented 9 years ago

:+1: I'll take a look asap!

mojavelinux commented 9 years ago

Closed in favor of #29.