search

asciidoctor / asciidoctor-extensions-lab

A lab for testing and demonstrating Asciidoctor extensions. Please do not use this code in production. If you want to use one of these extensions in your application, create a new project, import the code, and distribute it as a RubyGem. You can then request to make it a top-level project under the Asciidoctor organization.
Other
105 stars 101 forks source link

Fix class name for shell-session-treeprocessor. #26

Closed bk2204 closed 9 years ago

bk2204 commented 9 years ago

The name of the class was different between two of the extension files, resulting in an exception due to the inability to find the class.

mojavelinux commented 9 years ago

Thanks for the fix!

Btw, do you think it should be "ShellSession", "TerminalSession", "ConsoleSession" or something I haven't suggested yet? Terminology around the command line seems to be widely varied.

bk2204 commented 9 years ago

I think ShellSession is fine. It's descriptive, and it doesn't seem like there's an obviously better choice.

mojavelinux commented 9 years ago

Excellent! Thanks for providing your input.