asciidoctor / asciidoctor-firefox-addon

:wolf: An add-on for Mozilla Firefox that converts AsciiDoc files to HTML directly in the browser using Asciidoctor.js.
https://addons.mozilla.org/en-US/firefox/addon/asciidoctorjs-live-preview/
MIT License
32 stars 9 forks source link

not compatible with iceweasel 38.3 #20

Closed getreu closed 9 years ago

getreu commented 10 years ago

Plugin git version of today (latest commit bd972ecba5 Guillaume Grossetie Mogztter authored 18 days ago ) does not load into iceweasel 24.8.0: message: not compatible.

ggrossetie commented 10 years ago

Hello @getreu

I never tried my addon with Iceweasel... :smile: It was working before ? with an older version of the addon or an older version of Iceweasel ?

getreu commented 10 years ago

On 14/09/14 16:07, Guillaume Grossetie wrote:

Hello @getreu https://github.com/getreu

I never tried my addon with Iceweasel... :smile: It was working before ? with an older version of the addon or an older version of Iceweasel ?

Hello Guillaume,

Asciidoctor addon version 0.2.0 (asciidoctor 1.5.0.preview.1) still works fine for me with iceweasel 24.8.0.

Jens

ggrossetie commented 10 years ago

Ok thanks, I will have a look :)

2014-09-14 15:24 GMT+02:00 Jens Getreu notifications@github.com:

On 14/09/14 16:07, Guillaume Grossetie wrote:

Hello @getreu https://github.com/getreu

I never tried my addon with Iceweasel... :smile: It was working before ? with an older version of the addon or an older version of Iceweasel ?

Hello Guillaume,

Asciidoctor addon version 0.2.0 still works fine for me with iceweasel 24.8.0.

Jens

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-firefox-addon/issues/20#issuecomment-55525420 .

ggrossetie commented 9 years ago

@getreu Is that still the case with the Asciidoctor addon version 0.3.0 ?

getreu commented 9 years ago

With debian 8 comes iceweasel 31.7.0. The lasted update I could install was Asciidoctor.js Live Preview 0.2.3.1-signed.

Iceweasel did not allow me to update to Asciidoctor 0.3.2. The site: https://addons.mozilla.org/en-US/firefox/addon/asciidoctorjs-live-preview/ said: "Not available for Firefox 31.7.0"

ggrossetie commented 9 years ago

Firefox 31.7 is a bit old (early 2014) and Asciidoctor 0.3.2 is only compatible with Firefox 34+ (release 1st December 2014). Is there a way to update Iceweasel to a more recent release ?

getreu commented 9 years ago

In Debian stable (and derived distributions) the most recent version you can get at the moment is 31.8.0esr-1~deb8u1 through Debian backports. The standard version is 31.6. There was API change since so asciidoctor-firefox-addon should compile fine for all these older versions, doesn't it?

getreu commented 9 years ago

Debian backport brings firefox 38.3 (iceweasel). asciidoctor-firefox-addon 0.3.2 installs without error.

Unfortunately the asciidoc text of a local .adoc file is not rendered. It shows only the raw text.

Do I have to use some switch?

ggrossetie commented 9 years ago

Nothing happens when you enable/disable the extension (right click on the icon) ?

Is the extension working with remote files ? Le 25 sept. 2015 8:00 AM, "Jens Getreu" notifications@github.com a écrit :

Debian backport brings firefox 38.3 (iceweasel). asciidoctor-firefox-addon 0.3.2 installs without error.

Unfortunately the asciidoc text of a local .adoc file is not rendered. It shows only the raw text.

Do I have to use some switch?

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-firefox-addon/issues/20#issuecomment-143137240 .

getreu commented 9 years ago

I do not see the red/grey "A" icon. It is supposed to be in the upper right corner next to other add-on icons. It is also not on the "Additional Tools and features" customisation page.

getreu commented 9 years ago

Remote documents are rendered.

ggrossetie commented 9 years ago

Ok thanks, I will try to setup a Docker image with Debian and iceweasel.

ggrossetie commented 9 years ago

I was able to reproduce this issue. The problem is that the system.name is "Iceweasel" and not "Firefox": https://github.com/asciidoctor/asciidoctor-firefox-addon/blob/master/lib/main.js#L8

I'm using this hack to handle both mobile (Fennec) and Desktop (Firefox/Iceweasel) version. The mobile version doesn't have the same SDK and this is the only I found to determine what SDK is available.

Now this should be OK because we are using the same code for Firefox and Fennec.

iceweasel

I will publish the xpi file on GitHub because AMO is taking soooo long to accept new version. That way you will be able to use the latest version on Iceweasel !

mojavelinux commented 9 years ago

Nice work!

It amazes me that browsers can't agree to use the navigator element in a sensible way. Every browser wants to be Mozilla, Gecko or Chrome, except browsers that are Mozilla, and they want to be something else. Seriously the strangest situation.

getreu commented 9 years ago

Thank you!

ggrossetie commented 9 years ago

Done: https://github.com/asciidoctor/asciidoctor-firefox-addon/releases/tag/v0.4.1

getreu commented 9 years ago

It works! :)

ggrossetie commented 9 years ago

Yeah ! :tada: :+1: :smile: