search

asciidoctor / asciidoctor-firefox-addon

:wolf: An add-on for Mozilla Firefox that converts AsciiDoc files to HTML directly in the browser using Asciidoctor.js.
https://addons.mozilla.org/en-US/firefox/addon/asciidoctorjs-live-preview/
MIT License
32 stars 9 forks source link

URI with parameter does not render... #40

Closed cschanck closed 9 years ago

cschanck commented 9 years ago

For example: something like this:

http://<stuff>/adoc.adoc?at=436e9bd2b3ec2b83b704f35c898275a35367111a&raw

It fails to notice it is asciidoc with a parm. Sadface.

Works great on Chrome, but Firefox fails.

cschanck commented 9 years ago

I had left a review to this effect, but deleted it in favor of an issue here.

ggrossetie commented 9 years ago

Hi @cschanck, thanks for your report. Indeed the current regular expression is too restrictive: https://github.com/asciidoctor/asciidoctor-firefox-addon/blob/master/data/asciidocify.js#L8

I will update the code to have the same behavior as the Chrome Extension.

mojavelinux commented 9 years ago

I will update the code to have the same behavior as the Chrome Extension.

:+1:

I had noticed this as well. I'm looking forward to it!

cschanck commented 9 years ago

Excellent, excellent!

mojavelinux commented 9 years ago

:+1: