search

asciidoctor / asciidoctor-firefox-addon

:wolf: An add-on for Mozilla Firefox that converts AsciiDoc files to HTML directly in the browser using Asciidoctor.js.
https://addons.mozilla.org/en-US/firefox/addon/asciidoctorjs-live-preview/
MIT License
32 stars 9 forks source link

Fix extension for Firefox 57 quantum update #66

Closed r0ckarong closed 7 years ago

r0ckarong commented 7 years ago

The next version will be coming out in November and many people are currently using the betas. Can you prepare the extension to work with FF 57? Not sure how much of a refactor this will be because of the new rendering engines etc.

ggrossetie commented 7 years ago

Hello @r0ckarong, thanks for pointing this out. The plan is to use the new WebExtension API. Since this API is basically the Chrome Extension API, the Chrome extension will replaced the Firefox extension: https://github.com/asciidoctor/asciidoctor-chrome-extension

Some ground work have already been done: https://github.com/asciidoctor/asciidoctor-chrome-extension/pull/151

I'm waiting on the Asciidoctor.js 1.5.6 release to fix the last issues, then I will do a release of the "Chrome" extension that will be compatible witch Chrome, Firefox and Opera. Having said that, the "Chrome" extension should already be compatible with Firefox 57. If you want to give it a try, you can clone the asciidoctor-chrome-extension repository, and load the app directory (or create a zip from the app directory)

r0ckarong commented 7 years ago

What you mean is to add a temporary extension right? I tried installing a Zip of the app folder contents as an Add-on and it failed.

What I did to make it work was to go to about:debugging and then load the "manifest.json" from the app folder with the "Load temporary add-on" button. Now it seems to work fine.

Looking forward to seeing this work out of the box.

ggrossetie commented 7 years ago

What I did to make it work was to go to about:debugging and then load the "manifest.json" from the app folder with the "Load temporary add-on" button. Now it seems to work fine.

Yes, that's exactly what I meant, sorry if my reply wasn't clear enough :neutral_face:

Looking forward to seeing this work out of the box.

Did you install the extension from the Firefox Addon Website https://addons.mozilla.org/en/firefox/addon/asciidoctorjs-live-preview/ ? Please note that the review process on AMO (addons.mozilla.org) is really long and tedious so we've decided to distribute the extension through GitHub and not https://addons.mozilla.org anymore.

I will also submit the new version on AMO though but the review process can take months, so keep an eye on GitHub :wink:

mojavelinux commented 7 years ago

I will also submit the new version on AMO though but the review process can take months, so keep an eye on GitHub :wink:

I think this is the right strategy. We distribute on GitHub so that users who don't want to wait don't have to (which probably includes all the early adopters and testers). We distribute on AMO for those that can only install this way, but they'll have to be patient because of Mozilla's policy.

ggrossetie commented 7 years ago

@r0ckarong Could you try to install the latest version: https://addons.mozilla.org/en-us/firefox/addon/asciidoctorjs-live-preview ?

tracphil commented 7 years ago

That worked for me on Fedora 27 using FF 57. Thank you @r0ckarong !!

ggrossetie commented 7 years ago

Awesome :+1: I'm waiting to hear from @r0ckarong before closing this issue.

ggrossetie commented 7 years ago

Other users had confirmed that the extension is working fine. Closing...