search

asciidoctor / asciidoctor-fopub

A portable DocBook-to-PDF build command that wraps DocBook XSL and Apache FOP
MIT License
113 stars 37 forks source link

resolves #92 add support for generating XHTML #93

Closed mojavelinux closed 6 years ago

getreu commented 6 years ago

I tested you PR and it works nicely. Thank you! For me this is a read added value, because I do not have to maintain 2 different toolchains any more.

mojavelinux commented 6 years ago

I've given you access to this repository. If you accept, you can merge at will.

mojavelinux commented 6 years ago

@getreu Did you accept the invite yet?

getreu commented 6 years ago

Good morning. No I have not seen it. Maybe it poped up at some moment. I am not used to this workflow.

mojavelinux commented 6 years ago

Don't worry, it's GitHub's fault. They have a terrible workflow for this. That's why I asked.

Here's the link: https://github.com/asciidoctor Look for the invitation banner.

mojavelinux commented 6 years ago

I just enabled branch protection on the repo, so you'll need to approve the PR in order to merge it.

mojavelinux commented 6 years ago

:+1:

andrewcarver commented 5 years ago

Thanks for this enhancement, which seems very significant--in the way of making fopub more of an equivalent to a2x. Could someone tell me, also, whether the README has been updated to reflect this new facility? I do see one reference to 'xhtml' there, in the (brief) explanation of the -f option flag; but is that explanation new, and adequate for this new facility, or is it old, and obsolete? Many thanks! (If I need to open an issue, I'll of course do that!)

andrewcarver commented 5 years ago

Ah--I see it is a new addition as of Oct. 27. So I'll assume it explains all we need to do, to use fopub to generate xhtml (although it seemed to me the Issue 92 discussion portrayed it as an action more complicated than just using this flag...?)

andrewcarver commented 5 years ago

Oh, I guess the procedure-listing I was thinking of, was a procedure for doing this modification to fopub! So, I guess-- never mind! (Thanks again.)

mojavelinux commented 5 years ago

There's a brief mention of it in the README here:

https://github.com/asciidoctor/asciidoctor-fopub#fopub-option-flags

If you think more documentation is needed, please feel free to submit a docs update.