search

asciidoctor / asciidoctor-gradle-examples

A collection of example projects that demonstrates how to use the Asciidoctor Gradle plugin
http://asciidoctor.github.io/asciidoctor-gradle-examples
Other
146 stars 132 forks source link

Upgrade Gradle examples to use version 2.0 of plugin #50

Closed ghost closed 4 years ago

ghost commented 5 years ago

I'm totally confused over how to run version 2.0 of the asciidoctor-gradle-plugin.

Please upgrade the examples to use 2.0.

Thanks

gAmUssA commented 5 years ago

upvoting this. 2.0 has many significant changes it would be great to have updated examples

rwinch commented 5 years ago

I agree this would be a valuable change. Unfortunately I don't have the time to work on this at the moment. If anyone would like to help out, please comment here and specify which sample you would like to update. We can do one sample at a time to make it a smaller task.

ggrossetie commented 4 years ago

Version 3.0.0 is out! https://github.com/asciidoctor/asciidoctor-gradle-plugin I will update the examples and add a new example to explain how to create a custom task: https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/504

Is that OK @rwinch?

rwinch commented 4 years ago

That sounds great. Thank you @Mogztter

rwinch commented 4 years ago

@Mogztter I just branched the old code to 1.x and master should now be 3.x Perhaps a good approach would be to just get one sample working with the new plugin and temporarily delete the old samples. That way we get something working. What are your thoughts?

slonopotamus commented 4 years ago

You don't need to delete them, just exclude from settings.gradle.

rwinch commented 4 years ago

@slonopotamus I'm not sure what the buys us if they don't work. We can always recover them from the git history

ggrossetie commented 4 years ago

@rwinch Maybe we should publish the v1.x examples to: https://asciidoctor.github.io/asciidoctor-gradle-plugin/1.x/ and master to https://asciidoctor.github.io/asciidoctor-gradle-plugin/master/ ?

I don't think we want to maintain a v2.x branch based on the Asciidoctor Gradle Plugin 2.x.

rwinch commented 4 years ago

I don't think we want to maintain a v2.x branch based on the Asciidoctor Gradle Plugin 2.x.

I agree. At this point there seems little reason to put together a 2.x version of the plugins. For now, I'm closing this since we are working on 3.x. We can revisit this if there is sufficient demand for 2.x branch.