search

asciidoctor / asciidoctor-gradle-examples

A collection of example projects that demonstrates how to use the Asciidoctor Gradle plugin
http://asciidoctor.github.io/asciidoctor-gradle-examples
Other
146 stars 132 forks source link

Upgrade to Gradle wrapper 6 1 #54

Closed ggrossetie closed 4 years ago

ggrossetie commented 4 years ago

Use asciidoctorj 1.5.8.1 and the latest version of epub3 1.5.0-alpha.9. JRuby still crash my JVM from time to time... something about com.kenai.jffi.Foreign.

ggrossetie commented 4 years ago

I've upgraded asciidoc-to-revealjs-example to the latest version of Asciidoctor Gradle Plugin 3.0.0 because I couldn't figure it out which version of asciidoctor-reveal.js was compatible with the plugin.

rwinch commented 4 years ago

Thanks for the PR @Mogztter

I think we should try and get both the 1.x branch and master working. I think we should also try and keep the versions consistent (1.x should use the 1.x version of the plugin and master the 3.x version). If something is broken, I'm fine with deleting it initially.

I'm also much less worried about the older versions of the plugin, so if you can demo use with 3.x on master that would be best I think.

I'm going to close this PR since it mixes versions of the plugin.

ggrossetie commented 4 years ago

I think we should try and get both the 1.x branch and master working.

:+1:

I think we should also try and keep the versions consistent (1.x should use the 1.x version of the plugin and master the 3.x version). If something is broken, I'm fine with deleting it initially.

As mentioned by @slonopotamus I think we can just exclude them from settings.gradle no?

I'm also much less worried about the older versions of the plugin, so if you can demo use with 3.x on master that would be best I think.

That's what I did with the asciidoc-to-revealjs-example.

I'm going to close this PR since it mixes versions of the plugin.

I'm confused, you said you were fine to do one sample at a time? That's basically what I've done in this pull request. I've upgraded asciidoctor in the other samples to get a working build but I guess I can just exclude/remove them? And the Gradle upgrade is mandatory to use the 3.x version of the Asciidoctor Gradle plugin.

I also think it's easier to keep the original version in order to upgrade to the latest version. You can check the original code and make sure that all the showcased features are working with the 3.x version.

rwinch commented 4 years ago

As mentioned by @slonopotamus I think we can just exclude them from settings.gradle no?

What do we gain by keeping them around? I'd prefer to delete them if they don't work. We can always start the example from git history.

There are updates to projects that use Asciidoctor 1.x and then a change that does Asciidoctor 3.x. The updates to Asciidoctor 1.x should be on the 1.x branch. There shouldn't be 1.x usage of the plugin in master.

ggrossetie commented 4 years ago

What do we gain by keeping them around? I'd prefer to delete them if they don't work. We can always start the example from git history.

Alright.

There are updates to projects that use Asciidoctor 1.x and then a change that does Asciidoctor 3.x. The updates to Asciidoctor 1.x should be on the 1.x branch. There shouldn't be 1.x usage of the plugin in master.

So how should I proceed, remove everything except the asciidoc-to-revealjs-example?

rwinch commented 4 years ago

Yes that is a good start for master

ggrossetie commented 4 years ago

Alright let's do it! 🗑

ggrossetie commented 4 years ago

See https://github.com/asciidoctor/asciidoctor-gradle-examples/pull/55