asciidoctor / asciidoctor-gradle-plugin

A Gradle plugin that uses Asciidoctor via JRuby to process AsciiDoc source files within the project.
https://asciidoctor.github.io/asciidoctor-gradle-plugin/
Apache License 2.0
286 stars 122 forks source link

Add Java17 support #624

Open abelsromero opened 3 years ago

abelsromero commented 3 years ago

Ensure running on Java17 JVM.

Side note Spring 6 and SpringBoot 3 will use Java17 as baseline (Q4 2022). Not only that means a hugh spike in ppl upgrading, but Spring team uses the plugin so they'll be testing it before that date.

abelsromero commented 3 years ago

I work on it and right now is not possible given gradleTest incompaibilties, here is the full list of findings so far.

gradleEnterprise { buildScan { termsOfServiceUrl = 'https://gradle.com/terms-of-service' termsOfServiceAgree = 'yes'

    buildFinished { buildResult ->
        buildScanPublished { scan ->
            ['curl', '-s', '-d', "message=asciidoctor-gradle-plugin build scan: ${scan.buildScanUri}", 'https://webhooks.gitter.im/e/6ba348eef26407adc22a'].execute()
        }
    }
}

}

* `ValidateTaskProperties` validation class has been removed. Block needs to be removed or updated somehow
```groovy
tasks.withType(ValidateTaskProperties) { validateTaskProperties ->
    validateTaskProperties.failOnWarning = true
    validateTaskProperties.enableStricterValidation = true
}