search

asciidoctor / asciidoctor-gradle-plugin

A Gradle plugin that uses Asciidoctor via JRuby to process AsciiDoc source files within the project.
https://asciidoctor.github.io/asciidoctor-gradle-plugin/
Apache License 2.0
285 stars 120 forks source link

Support latest worker API methods for Gradle 8.0 compatibility #651

Closed ghale closed 1 year ago

ghale commented 1 year ago

Gradle 8.0 will retire the deprecated WorkerExecutor.submit() method. This PR changes the plugin's use of the worker API to use the new methods introduced in Gradle 5.6. This effectively raises the minimum supported Gradle version to 5.6 in order to use the the only worker API methods now supported in Gradle 8.0. I've updated compatibility-tests.gradle to reflect this and test against newer versions, but I'm not entirely sure what the rationale was for the selection of versions that were in there previously. If any of those look wrong, I'm happy to adjust.

There are some failing javascript integration tests, but it looks like those are failing on the main repository as well. I don't think they are related to these changes.

ysb33r commented 1 year ago

@ghale Would you please redo this against the development-4.x branch?

I am not going to spend effort making 3.x compatible with 8.0.