search

asciidoctor / asciidoctor-gradle-plugin

A Gradle plugin that uses Asciidoctor via JRuby to process AsciiDoc source files within the project.
https://asciidoctor.github.io/asciidoctor-gradle-plugin/
Apache License 2.0
285 stars 120 forks source link

The property "srcDir" in AbstractAsciidoctorBaseTask should be annotated as input property #654

Closed bmuschko closed 1 year ago

bmuschko commented 1 year ago

Right now the property srcDir is marked with @Internal and therefore changes to the files in the source directory are not picked up properly.

https://github.com/asciidoctor/asciidoctor-gradle-plugin/blob/master/base/src/main/groovy/org/asciidoctor/gradle/base/AbstractAsciidoctorBaseTask.groovy#L116

What was the thought process of marking this as a property to be ignored?

ysb33r commented 1 year ago

Not all files in the directory will contribute to the eventual documentation being published. The input files are calculated from the getSourceFileTree() and getSecondarySourceFileTree() methods which are annotated with @InputFiles.

https://github.com/asciidoctor/asciidoctor-gradle-plugin/blob/a70bd00b654976ceba099708f0b216063222ba77/base/src/main/groovy/org/asciidoctor/gradle/base/AbstractAsciidoctorBaseTask.groovy#L335

bmuschko commented 1 year ago

Thanks for the explanation. I am going to close the issue.