search

asciidoctor / asciidoctor-gradle-plugin

A Gradle plugin that uses Asciidoctor via JRuby to process AsciiDoc source files within the project.
https://asciidoctor.github.io/asciidoctor-gradle-plugin/
Apache License 2.0
283 stars 120 forks source link

Minor updates #701

Closed Goooler closed 6 months ago

Goooler commented 6 months ago

We can kick these things by enabling @renovate-bot and keep this repo up to date.

Goooler commented 6 months ago

I'm trying to upgrade Gradle 8 for this project, will send a PR after finishing that.

ysb33r commented 6 months ago

I'm trying to upgrade Gradle 8 for this project, will send a PR after finishing that.

If you can get it to work, great, but the requirement is that the plugin suite has to compatible with a minimum of Gradle 7.0.2

Goooler commented 6 months ago

I bumped it to Gradle 7.6 first, but 1 test failed, I'm not sure why, see

ysb33r commented 6 months ago

I bumped it to Gradle 7.6 first, but 1 test failed, I'm not sure why, see

* [Gradle 7.6.3 Goooler/asciidoctor-gradle-plugin#43](https://github.com/Goooler/asciidoctor-gradle-plugin/pull/43)

* https://scans.gradle.com/s/pebpcysnv2ne6/tests/overview?outcome=FAILED

It probably has to do with how properties are interpreted. If you change the 'Can generate a asciidoctorconfigfile' test in AsciidoctorEditorConfigIntegrationSpec to rather contain the following, I think it will work

        attrFile.text = ":${key3}: ${value3}\n"

        new File(projectDir,'gradle.properties').text = """
        group=${groupName}
        version=${projVer}
        """.stripIndent()

        getGroovyBuildFile("""
        apply plugin : 'org.asciidoctor.jvm.base'
Goooler commented 6 months ago

It works! Addressing the update to #704.