asciidoctor / asciidoctor-gradle-plugin

A Gradle plugin that uses Asciidoctor via JRuby to process AsciiDoc source files within the project.
https://asciidoctor.github.io/asciidoctor-gradle-plugin/
Apache License 2.0
283 stars 120 forks source link

Set Java Toolchain to enforce module JVM to 8 #703

Closed abelsromero closed 6 months ago

abelsromero commented 6 months ago

Otherwise the value of 'org.gradle.jvm.version' is set to the JVM used during build.

abelsromero commented 6 months ago

I see development-4.x branch has a quick fix for the description too, but that is removing the actual description in the POM and simply inserting a dot. I think we should fix it too before any patch release.

abelsromero commented 6 months ago

I think GH is about to crash, I saw the "oops page" and CI is showing weird errors.

I validated the change locally building with JDK 11 and checking the modules

find . -name "asciidoctor-gradle-*.module" -exec cat {} \; | grep 'org.gradle.jvm.version'

image

Without the fix I saw 11.