Closed romkavt closed 3 years ago
Safari does not support lookbehind in regular expressions (sigh): https://caniuse.com/js-regexp-lookbehind
To accommodate Safari we should rewrite this regular expression to avoid using lookbehind. It might require to do additional checks.
@romkavt The line number does not correspond but the error tells me that this is related to a regular expression. Do you have a more complete stacktrace ?
@Mogztter can we get this fix for Safari merged in?
@secdim If you could confirm that https://github.com/Mogztter/asciidoctor-kroki/pull/228 actually resolves this issue in Safari that would be helpful. I don't have Safari so I can't make sure that my fix is sufficient.
@secdim If you could confirm that #228 actually resolves this issue in Safari that would be helpful. I don't have Safari so I can't make sure that my fix is sufficient.
I merged this 'by hands' in our installation and I confirm the fix works well on Mac OS Safari.
Thanks for confirming, I will merge the pull request!
@secdim If you could confirm that #228 actually resolves this issue in Safari that would be helpful. I don't have Safari so I can't make sure that my fix is sufficient.
Yes, I have tested it and it fixes Safari issue.
@secdim Thanks for confirming, I will release a new version today.
Version https://github.com/Mogztter/asciidoctor-kroki/releases/tag/v0.14.0 has been released 🎉
Hello!
asciidoctor-kroki.js version 0.12 On Safari 14.0.3 with MacOS 10.15.7 (Catalina) the PlantUML diagrams doesn't render with the following error:
Thanks for help in advance