"invalid group specifier name" on MacOS Safari

[romkavt]

Hello!

asciidoctor-kroki.js version 0.12 On Safari 14.0.3 with MacOS 10.15.7 (Catalina) the PlantUML diagrams doesn't render with the following error:

[Error] SyntaxError: Invalid regular expression: invalid group specifier name
    (anonymous function) (asciidoctor-kroki.js:18656)

Thanks for help in advance

[ggrossetie]

Safari does not support lookbehind in regular expressions (sigh): https://caniuse.com/js-regexp-lookbehind

https://github.com/Mogztter/asciidoctor-kroki/blob/05623c9ea0bbf29c11bad848ee529f8694b9f2f3/src/preprocess.js#L106

To accommodate Safari we should rewrite this regular expression to avoid using lookbehind. It might require to do additional checks.

[ggrossetie]

@romkavt The line number does not correspond but the error tells me that this is related to a regular expression. Do you have a more complete stacktrace ?

[secdim]

@Mogztter can we get this fix for Safari merged in?

[ggrossetie]

@secdim If you could confirm that https://github.com/Mogztter/asciidoctor-kroki/pull/228 actually resolves this issue in Safari that would be helpful. I don't have Safari so I can't make sure that my fix is sufficient.

[romkavt]

@secdim If you could confirm that #228 actually resolves this issue in Safari that would be helpful. I don't have Safari so I can't make sure that my fix is sufficient.

I merged this 'by hands' in our installation and I confirm the fix works well on Mac OS Safari.

[ggrossetie]

Thanks for confirming, I will merge the pull request!

[secdim]

@secdim If you could confirm that #228 actually resolves this issue in Safari that would be helpful. I don't have Safari so I can't make sure that my fix is sufficient.

Yes, I have tested it and it fixes Safari issue.

[ggrossetie]

@secdim Thanks for confirming, I will release a new version today.

[ggrossetie]

Version https://github.com/Mogztter/asciidoctor-kroki/releases/tag/v0.14.0 has been released 🎉