search

asciidoctor / asciidoctor-kroki

Asciidoctor.js extension to convert diagrams to images using Kroki!
https://kroki.io/
MIT License
151 stars 51 forks source link

Fix how to soft set a kroki attribute in Antora (use a trailing @ on the value, not the attribute) #308

Closed sturtison closed 2 years ago

sturtison commented 2 years ago

Hi @Mogztter while reading the README.md, following and using the guide, it seems that the info below is perhaps out of date.

https://github.com/Mogztter/asciidoctor-kroki/blob/0cfab7d60eeccb6bf64b17928156054ea6c799a9/README.md?plain=1#L361-L367

The antora docs for soft set describe that the @ should trail the value, not the attribute.

The actual result is line should hold kroki-default-format: png@

I'm raising a PR from my fork using this issue number if it's suitable for you to accept.

/edits: Format result line.

ggrossetie commented 2 years ago

fixed in #309