search

asciidoctor / asciidoctor-kroki

Asciidoctor.js extension to convert diagrams to images using Kroki!
https://kroki.io/
MIT License
149 stars 50 forks source link

Support diagrams.net (draw.io) #392

Closed JkbLskw closed 1 year ago

JkbLskw commented 2 years ago

In the kroki documentation, the diagram type "diagrams.net" (draw.io) is specified as experimental. Unfortunately I couldn't find an issue regarding adding this diagram type to the asciidoctor-kroki extension.

Are there any plans for this?

ggrossetie commented 2 years ago

Sure, we can add it. Feel free to submit a pull request to add diagramsnet support.

We should also mention in the README that diagrams.net is not available on https://kroki.io.

JkbLskw commented 2 years ago

Since kroki.io support is missing, I couldn't write a test for converting diagramsnet diagram to an image.

I only tested it locally with my own kroki server. Should I post the test result to this issue?

JkbLskw commented 2 years ago

I misunderstood the tests. No real connection to kroki.io is created at all. I added the test to convert a diagrams.net diagram to an image.

FWiesner commented 1 year ago

Hello @Mogztter. We would love seeing a new release cut with this change :)