asciidoctor / asciidoctor-kroki

Asciidoctor.js extension to convert diagrams to images using Kroki!
https://kroki.io/
MIT License
146 stars 47 forks source link

wireviz block type is rendered as a literalblock with ruby gem v0.9.1 #440

Closed lomax closed 3 months ago

lomax commented 7 months ago

Trying to render the wireviz block from example

[wireviz]
....
connectors:
  X1:
    type: D-Sub
    subtype: female
    pinlabels: [DCD, RX, TX, DTR, GND, DSR, RTS, CTS, RI]
  X2:
    type: Molex KK 254
    subtype: female
    pinlabels: [GND, RX, TX]

cables:
  W1:
    gauge: 0.25 mm2
    length: 0.2
    color_code: DIN
    wirecount: 3
    shield: true

connections:
  -
    - X1: [5,2,3]
    - W1: [1,2,3]
    - X2: [1,3,2]
  -
    - X1: 5
    - W1: s
....

with ruby gem v0.9.1 asciidoctor -r asciidoctor-kroki wireviz.adoc results in literalblock instead of imageblock kroki.

Is there a reason why SUPPORTED_DIAGRAM_NAMES is not altered in #423?

As v0.9.1 release mentioned Wireviz support shouldn't CI catch this issue?

ggrossetie commented 3 months ago

Fixed in 0.10.0