search

asciidoctor / asciidoctor-kroki

Asciidoctor.js extension to convert diagrams to images using Kroki!
https://kroki.io/
MIT License
146 stars 47 forks source link

Create an Antora adapter to write diagrams to the output images directory #5

Closed ggrossetie closed 4 years ago

ggrossetie commented 4 years ago

Otherwise the diagrams won't be resolved. Currently it's not possible to use the kroki-fetch-diagram feature in Antora.

ggrossetie commented 4 years ago

resolved in 54cf7da44f373a2809070ee1775e567b062c217e

akosma commented 4 years ago

Can we now save diagrams locally in Antora websites? Yeah!

akosma commented 4 years ago

Is this documented somewhere? Is there something to configure to make it work?

ggrossetie commented 4 years ago

Is this documented somewhere?

No but I heard it's working :sweat_smile:

Is there something to configure to make it work?

If you define kroki-fetch-diagram it should work.

akosma commented 4 years ago

It does work! However in our case (we use a custom built Docker image to drive builds both locally and on our CI/CD pipeline with the same config) we had to yarn global add mkdirp unxhr to make it work, but it did work!

akosma commented 4 years ago

For info, our Docker image builds FROM antora/antora:2.2.0

akosma commented 4 years ago

And I've just tried it together with asciidoctor-reveal.js, and it also works perfectly well.

ggrossetie commented 4 years ago

It does work!

Cool 👍 @akosma We should probably add a mention somewhere in the README. If you want to update the README I will gladly merge it 😉

However in our case (we use a custom built Docker image to drive builds both locally and on our CI/CD pipeline with the same config) we had to yarn global add mkdirp unxhr to make it work, but it did work!

I don't remember why I didn't add unxhr as a dependency... I will open an issue to track it.