search

asciidoctor / asciidoctor-latex

:triangular_ruler: Add LaTeX features to AsciiDoc & convert AsciiDoc to LaTeX
http://asciidoctor.org
Other
112 stars 26 forks source link

Appearance of block_dlist for tex backend #31

Open jxxcarlson opened 9 years ago

jxxcarlson commented 9 years ago

@jirutka, could you take a look at block_dlist for the tex backend? I think it is fine except for an esthetic point: when an item is a sublist, the sublist should start on new line. If this is something you could address, that would be great. Is the dlist code yours? I don't recognze it. Looks too pro:-)

jirutka commented 9 years ago

How can I address it? What dlist code do you mean?

jxxcarlson commented 9 years ago

Its this code:

https://github.com/asciidoctor/asciidoctor-latex/blob/master/lib/asciidoctor/latex/node_processors.rb#L224-L239

the tex output would look better if when a dlist has lists as items, those lists start underneath the definition term. Otherwise the first item is out of line line with the others and while it succeeds syntactically and semantically, it fails esthetically.

See what I mean by looking at the pdf output arising from block_dlist.tex

I don’t recall writing this code and thought perhaps tat you did.

On Apr 27, 2015, at 7:03 PM, Jakub Jirutka notifications@github.com wrote:

How can I address it? What dlist code do you mean?

— Reply to this email directly or view it on GitHub.

jirutka commented 9 years ago

There’s a nice feature in git called blame, see this. I’ve just fixed some (technical) bug, don’t know how it looks in LaTeX. So feel free to edit it as you like. :)

jxxcarlson commented 9 years ago

I don’t see your changes. Where do I look?

I see that the code is Otavo’s. Blame is great except possibly for the name_.

On Apr 27, 2015, at 7:47 PM, Jakub Jirutka notifications@github.com wrote:

There’s a nice feature in git called blame, see this https://github.com/asciidoctor/asciidoctor-latex/blame/master/lib/asciidoctor/latex/node_processors.rb#L224-L239. I’ve just fixed some (technical) bug, don’t know how it looks in LaTeX. So feel free to edit it as you like. :)

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-latex/issues/31#issuecomment-96618699.

mojavelinux commented 9 years ago

Blame is great except possibly for the name

Unfortunately true. It is terminology that was inherited from subversion and now deeply embedded in the revision control community. The proper name for it is "annotate". SVN has even aliased the term "praise" since.

jirutka commented 9 years ago

Actually this name is correct in this case – James needed to find who to blame for the code. :smirk_cat:

jxxcarlson commented 9 years ago

Ah — but it was more praise than blame! Very good code (by @otavo) — needs one esthetic tweak.

On Apr 28, 2015, at 7:37 AM, Jakub Jirutka notifications@github.com wrote:

Actually this name is correct in this case – James needed to find who to blame for the code.

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-latex/issues/31#issuecomment-96851085.