Closed tribut closed 6 years ago
This looks good. I agree you have matched the behavior of Asciidoctor PDF (and the DocBook output).
Could you add a doctest for this case?
Removed check for node.special
and added doctests. I've also added an unrelated commit to ignore .bundle
and vendor
and I hope that's alright.
I've also added an unrelated commit to ignore .bundle and vendor and I hope that's alright.
Oops, our paths just crossed. I just added the .bundle entry to .gitignore.
I prefer to put the gems under .bundle so only one entry is needed.
bundle --path=.bundle/gems
Does that work for you? The vendor directory gives me shivers.
This looks fantastic. My only request would be to move the index section test into a separate file. The inline_indexterm should be focused just on the terms. Perhaps create a file called index_section or and move the last test into it. Otherwise, good as :medal_sports: !
Sure, I'll move the test to another file. Also, if you don't mind, I'll just add /vendor/
to the .gitignore. After all, it is standard practice and should not scare you too much hidden in .gitignore :>
Rebased, squashed and made the requested changes.
Seems reasonable to me.
(While I recognize /vendor/ is standard practice, I'll never be able to accept it personally for my own workflow because it's just not logical...but then again, I've always been an outsider).
@tribut This is wonderful!
:+1:
Implemented
.tex
output for index generation. This should be feature-equivalent to whatasciidoctor-pdf
is doing (see https://github.com/asciidoctor/asciidoctor-pdf/pull/562).Note that this does not honor the level of the "index" section, so
and
currently behave the same. That is a limitation of the makeidx package.