fix environment_literal block

asciidoctor / asciidoctor-latex

:triangular_ruler: Add LaTeX features to AsciiDoc & convert AsciiDoc to LaTeX

http://asciidoctor.org

Other

114 stars 26 forks source link

fix environment_literal block #66

Closed mojavelinux closed 7 years ago

mojavelinux commented 7 years ago

add environment_literal to list of node types
add test for envv.equation

jxxcarlson commented 7 years ago

@mojavelinux This PR produces the correct html but (for me) produces empty tex output. Try bundle exec asciidoctor-latex -s bar.adoc where bar.adoc is as below.

[envv.equation]
....
(a^2 + b^2)^2 = (a^2)^2 + 2a^2b^2 + (b^2)^2
....

mojavelinux commented 7 years ago

I noticed that. The problem is that environment_literal only seems to be mapped in the HTML converter. It never got a tex converter...at least I don't see it referenced anywhere. Are you sure this worked before?

mojavelinux commented 7 years ago

When an extension creates a block with a custom context, then there must be a converter method to match. Otherwise, the converter won't know how to handle the block.

jxxcarlson commented 7 years ago

Aha -- that is probably it. I am on a bus right now. Will look at it when I get home.

Sent from my iPhone

On Jul 27, 2017, at 2:01 PM, Dan Allen notifications@github.com wrote:

I noticed that. The problem is that environment_literal only seems to be mapped in the HTML converter. It never got a tex converter...at least I don't see it referenced anywhere. Are you sure this worked before?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.