search

asciidoctor / asciidoctor-maven-examples

A collection of example projects that demonstrates how to use the Asciidoctor Maven plugin.
http://asciidoctor.org/docs/asciidoctor-maven-plugin
Other
196 stars 243 forks source link

Example for PlantUML diagrams without Graphviz dot installation #244

Closed kriegaex closed 8 months ago

kriegaex commented 8 months ago

Hello.

I do not expect you to merge this as-is, feel free to

abelsromero commented 8 months ago

I do not expect you to merge this as-is, feel free to

I do in fact expect to be able to get any contribution in with the original authoring and attributions :smile: I added a single comment, if we can get that the PR goes it as-is.

You can mention it in the repo or do the change yourself, they'll be happy to review. Don't take it wrong, we are distributed teams and I am focused on the maven/java side of things and don't use 'diagram' myself. You'll be able to provide a better description than me. The exact file is this one https://github.com/asciidoctor/asciidoctor-diagram/blob/master/docs/modules/ROOT/pages/diagram_types/plantuml.adoc

kriegaex commented 8 months ago

You can mention it in the repo or do the change yourself, they'll be happy to review. Don't take it wrong, we are distributed teams

But at least, probably you know each other.

and I am focused on the maven/java side of things

Well, Smetana is a Java port of (a subset of) the original code.

and don't use 'diagram' myself. You'll be able to provide a better description than me. The exact file is this one https://github.com/asciidoctor/asciidoctor-diagram/blob/master/docs/modules/ROOT/pages/diagram_types/plantuml.adoc

Don't get me wrong either, but for the last two weeks or so I have spent more time creating issues and PRs in several OSS projects, instead of getting anything done in my own project, just because I am too nice. I need to focus, too.

BTW, if you know a lot about the Maven and Java side of things, can you happen to answer this Zulip question?

abelsromero commented 8 months ago

Ported changes to https://github.com/asciidoctor/asciidoctor-maven-examples/pull/245