Fix diagram images path in site modules - Githubissues

asciidoctor / asciidoctor-maven-plugin

A Maven plugin that uses Asciidoctor via JRuby to process AsciiDoc source files within the project.

http://asciidoctor.org

Apache License 2.0

317 stars 122 forks source link

Fix diagram images path in site modules #762

Open abelsromero opened 7 months ago

abelsromero commented 7 months ago

Thank you for taking your time to talk with us!

What is this issue about?

[x] Bug report
[ ] Feature request
[ ] Question

Description

Using asciidoctorj-diagram with the maven-site modules causes diagram images to be created in the source path.

Environment information

asciidoctor-maven-plugin version: 2.2.5
asciidoctorj version: 2.5.11
asciidoctorj-diagram version: 2.2.17
Maven, Java and OS version: at least Windows and Linux https://github.com/asciidoctor/asciidoctor-maven-examples/issues/238 https://asciidoctor.zulipchat.com/#narrow/stream/279642-users/topic/Use.20PlantUML.20in.20Maven.20Site

abelsromero commented 7 months ago

The issue is caused because the site converter converts to String and then Doxia (Maven's site component) creates the image files from it. Hence asciidoctor-diagram generates images in the only path available, the one where the source is.

The current workaround of setting imagesoutdir attribute won't work when the sources are found in different sub-folders.