Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
[x] Bugfix for converter-doxia-module which is the continuation of the previous one.
[x] Feature for the new parser-doxia-module
[ ] Documentation
[ ] Refactor
[ ] Build improvement
[ ] Other (please describe)
What is the goal of this pull request?
Port fixes for #763 from branch v2.2.x to main (v3.0.x).
Are there any alternative ways to implement this?
I found out parser-doxia-module is going to need a new implementation different from v2.2.x :disappointed: . ~The later it is portable to converted-doxia-module only.~ I could refactor the fix into re-usable code shared in the "commons" module. To avoid users of the asciidoctor-maven-plugin pulling doxia dependencies, I added the required doxia-sink-api as provided, but I admit that's a quick-hack.
Eventually, we'd need a "commons" only for site modules.
Are there any implications of this pull request? Anything a user must know?
No
Is it related to an existing issue?
- [x] Yes https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/763
- [ ] No
*Finally, please add a corresponding entry to CHANGELOG.adoc*
I am adding this as a bug fix since it was present previously
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Port fixes for #763 from branch v2.2.x to main (v3.0.x).
Are there any alternative ways to implement this?
I found out
parser-doxia-moduleis going to need a new implementation different from v2.2.x :disappointed: . ~The later it is portable toconverted-doxia-moduleonly.~ I could refactor the fix into re-usable code shared in the "commons" module. To avoid users of theasciidoctor-maven-pluginpulling doxia dependencies, I added the requireddoxia-sink-apiasprovided, but I admit that's a quick-hack. Eventually, we'd need a "commons" only for site modules.Are there any implications of this pull request? Anything a user must know?
No
Is it related to an existing issue?
- [x] Yes https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/763 - [ ] No *Finally, please add a corresponding entry to CHANGELOG.adoc* I am adding this as a bug fix since it was present previously