search

asciidoctor / asciidoctor-pdf

:page_with_curl: Asciidoctor PDF: A native PDF converter for AsciiDoc based on Asciidoctor and Prawn, written entirely in Ruby.
https://docs.asciidoctor.org/pdf-converter/latest/
MIT License
1.14k stars 500 forks source link

Docs: table-caption-end should be table-caption-side #2148

Closed ponchofiesta closed 2 years ago

ponchofiesta commented 2 years ago

In the theming guide under table key there is caption-end: top|bottom. Isn't this caption-side?

In my test caption-end had no effect, caption-side worked to bring down below the caption.

mojavelinux commented 2 years ago

The official docs for the theming guide is now located at https://docs.asciidoctor.org/pdf-converter/latest/theme/keys/. The theming guide in the repository will soon be removed and redirected.

The caption-end key refers to Asciidoctor PDF 2. That's the correct name for the key in that version, and it is tested. See https://github.com/asciidoctor/asciidoctor-pdf/blob/main/spec/table_spec.rb#L2426-L2443 However, the caption-side key will continue to work for backwards compatibility with Asciidoctor PDF 1.6.

If you are looking for the docs for Asciidoctor PDF 1.6, you can find them in the v1.6.x branch. See https://github.com/asciidoctor/asciidoctor-pdf/blob/v1.6.x/docs/theming-guide.adoc