search

asciidoctor / asciidoctor-pdf

:page_with_curl: Asciidoctor PDF: A native PDF converter for AsciiDoc based on Asciidoctor and Prawn, written entirely in Ruby.
https://docs.asciidoctor.org/pdf-converter/latest/
MIT License
1.14k stars 501 forks source link

Move font-color row up in the List Category Keys ulist-marker and ulist-marker<type> tables #2392

Closed FabienLaunay closed 1 year ago

FabienLaunay commented 1 year ago

What:

  1. In the ulist-marker table, move the font-color row above the font-size row.
  2. In the ulist-marker- table, move the font-color row above the font-family row.

Why: Keep consistency with other Theme Keys Reference tables in which keys are ordered alphabetically.

Remark: Sorry to bother you with this perfectionist pull request ;-) Feel free to ignore it as I guess you must be quite busy developing this great product.

FabienLaunay commented 1 year ago

Oops... I forgot to create an issue so that I could link that pull request to it. I apologize for that. Don't hesitate to tell me if I should do so. Thanks.

mojavelinux commented 1 year ago

Sorry to bother you with this perfectionist pull request ;-)

This is a message from one perfectionist to another, so I greatly appreciate your revisions!

For docs revisions, you don't need to open an issue. Sending a PR is perfectly fine. Issues are primarily for software changes or for new material in the docs.