search

asciidoctor / asciidoctor-pdf

:page_with_curl: Asciidoctor PDF: A native PDF converter for AsciiDoc based on Asciidoctor and Prawn, written entirely in Ruby.
https://docs.asciidoctor.org/pdf-converter/latest/
MIT License
1.14k stars 500 forks source link

Upgrade prawn-svg #2469

Closed henry-hsieh closed 8 months ago

henry-hsieh commented 8 months ago

Hello,

I'm using bytefield-svg which is heavily using the dominant-baseline of SVG attribute to make the texts center-aligned. However, prawn-svg cannot recognize the attribute. Therefore, I made a PR to support the feature, and it has been merged into main branch successfully. Moreover, the newest release 0.33.0 has included the feature. I hope the asciidoctor-pdf can upgrade it as well.

Thank you!

mojavelinux commented 8 months ago

Three of the visual tests are failing. However, when I inspect the changes manually, I cannot perceive any difference, so likely it is some sort of rounding difference. Therefore, I'll update the expected output files and proceed.

henry-hsieh commented 8 months ago

OK. Thanks for your help!

henry-hsieh commented 8 months ago

Hi @mojavelinux , is it possible to upgrade the version of the release recently? I want to update the dependency of my project. Thank you!

mojavelinux commented 8 months ago

I don't have any plans for an immediate release, but once I come back around to the project and make a few other updates, I'll push out a release.

henry-hsieh commented 8 months ago

OK. I'll wait for the release. Thanks!