search

asciidoctor / asciidoctor-pdf

:page_with_curl: Asciidoctor PDF: A native PDF converter for AsciiDoc based on Asciidoctor and Prawn, written entirely in Ruby.
https://docs.asciidoctor.org/pdf-converter/latest/
MIT License
1.13k stars 500 forks source link

resolves #2521 don't hyphenate autolink when hyphenation is enabled #2513

Closed meonkeys closed 1 month ago

meonkeys commented 3 months ago

(see commit log message for details, including caveats)

(sorry about the force push, I won't do any more of those)

mojavelinux commented 1 month ago

I've updated the implementation to use a skipping filter instead of a backreference. I think this is a cleaner and more stable approach.

mojavelinux commented 1 month ago

Once the tests pass, I will accept this change. A few notes about future PRs that will help them get merged faster.

First, every non-docs PR should have an associated issue. Without an issue, PRs mostly get ignored because they lack context and are difficult to track using our process. Before submitting a PR, always start by creating an issue. The issue is where you can discuss implementation details so they don't get lost in the PR. These comments do not belong in the commit message. You can mention in the issue that you intend to submit a PR, which will help get the issue scheduled.

Both the CHANGELOG entry and the PR should reference the issue.

Aside from that, I'd actually say the PR was pretty good. Don't worry about force pushing in a PR. That is completely acceptable. The main goal is that you want to end up with only one commit.