search

asciidoctor / asciidoctor-reveal.js

:crystal_ball: A reveal.js converter for Asciidoctor and Asciidoctor.js. Write your slides in AsciiDoc!
http://asciidoctor.org
Other
287 stars 189 forks source link

cdn cannot be used anymore #485

Closed hans-d closed 1 year ago

hans-d commented 1 year ago

With https://github.com/asciidoctor/asciidoctor-reveal.js/pull/427, there is now a hardcoded path for /dist for both the script and the css. When using :revealjsdir: https://cdnjs.cloudflare.com/ajax/libs/reveal.js/4.1.2 this breaks.

toastal commented 1 year ago

When this bug is tackled, it should be known that there are good reasons to push for preferring self-hosting Reveal.js over using a CDN for user security/privacy. At a bare minimum, a subresource integrity hash should be required--like :revealjs-integrity-{css,js}:--and with the attributes missing, the document should fail to build with the CDN option.

ggrossetie commented 1 year ago

We are moving away from cdnjs to jsdelivr.com

The following should work:

revealjsdir: https://cdn.jsdelivr.net/npm/reveal.js@4.1.2

I agree with @toastal using a self-hosted version is probably safer and it allows to build/preview a presentation offline which is reassuring especially with flaky Internet connection at conferences.