search

asciidoctor / asciidoctor-reveal.js

:crystal_ball: A reveal.js converter for Asciidoctor and Asciidoctor.js. Write your slides in AsciiDoc!
http://asciidoctor.org
Other
287 stars 189 forks source link

`muted` on local video doesn't work? #523

Open rben01 opened 7 months ago

rben01 commented 7 months ago

In asciidoctor-reveal.js a simple video block like 

video::./my-vid.mp4[options="autoplay,muted"]

does autoplay, but is not muted — indeed, muted is nowhere to be found in the resulting HTML.

This issue appears to be fixed in Asciidoctor proper (see https://github.com/asciidoctor/asciidoctor/issues/3408); maybe that just needs to make its way into asciidoctor-reveal.js?

ggrossetie commented 7 months ago

This issue appears to be fixed in Asciidoctor proper (see https://github.com/asciidoctor/asciidoctor/issues/3408); maybe that just needs to make its way into asciidoctor-reveal.js?

You're probably right. To support this feature, you will need to copy/paste/adapt the code from Asciidoctor into https://github.com/asciidoctor/asciidoctor-reveal.js/blob/master/templates/video.html.slim