Asciidoctor compact theme and build script change

asciidoctor / asciidoctor-stylesheet-factory

!DEPRECATED! This was the utility project for producing the default stylesheet for the HTML converter in Asciidoctor. The source of the default stylesheet now lives in the main Asciidoctor repository.

Other

175 stars 87 forks source link

Asciidoctor compact theme and build script change #11

Closed nerk closed 7 years ago

nerk commented 10 years ago

This adds a compact version of the default Asciidoctor theme, 'asciidoctor-compact'. Smaller font and less spacing between elements.

The build script failed when invoked directly, because it used 'let' which is not known to '/bin/sh'.

leif81 commented 10 years ago

:+1: I'm a fan of the compact theme idea. I've used it in Brackets. This compact theme has got me especially excited thinking about combining this with PR #12 and #13 that make printing asciidoctor HTML more compelling. A shorter print version is a nice theme to have available.

A couple things:

The print styles, @import "components/print"; should probably be added to asciidoctor-compact.scss?
The font size in the #preamble > .paragraph seems large and may have been overlooked (noticeable in asciidoctor-writers-guide.adoc). Not sure if this was deliberate or not.

mojavelinux commented 10 years ago

I'll be looking at this pull request during or shortly after getting 1.5.0 released.

nerk commented 9 years ago

Leif, thanks for your comments. I applied the changes you suggested to the asciidoctor-compact theme. It's already part of the Brackets extension. I'll update the official Brackets plugin repository once the final 1.5 release of Asciidoctor is out.

mojavelinux commented 9 years ago

Now that 1.5.0 is out, I'll be sure to look into getting this merged soon. Great stuff!

nerk commented 9 years ago

This is outdated as of 1.5.0. Just grab https://github.com/nerk/asciidoctor-stylesheet-factory/blob/master/sass/asciidoctor-compact.scss for an updated version. Currently, this is good enough for me for the brackets preview, but is a bit of a quick hack and could certainly use some tuning.

Maybe some SASS control directives should be put into original asciidoctor.scss to allow for creating the original and compact styles from the same source?

nerk commented 9 years ago

Also needed are appropriate settings, of course: https://github.com/nerk/asciidoctor-stylesheet-factory/blob/master/sass/settings/_asciidoctor-compact.scss

mojavelinux commented 9 years ago

I agree, compact should probably be a variation on the default theme so they stay in sync.

testn commented 9 years ago

@nerk , any chance to get this one merged?

mojavelinux commented 9 years ago

I'm still holding on this one because of the refactoring mentioned in #2 and #23. However, I could take a look and see if I can merge it before then so it isn't necessary to wait. My attention has just been elsewhere in Asciidoctor recently (mostly PDF).

nerk commented 9 years ago

Unfortunately, I do not have enough skills regarding typography to make the compact style really good. @mojavelinux would certainly be the right person. The current stylesheet was more of a hack to make something work for the Brackets preview.

nerk commented 7 years ago

This is completely outdated. In addition, the compact theme needs a lot of work before it is ready.