resolves #19 - migrate to Foundation 5

asciidoctor / asciidoctor-stylesheet-factory

!DEPRECATED! This was the utility project for producing the default stylesheet for the HTML converter in Asciidoctor. The source of the default stylesheet now lives in the main Asciidoctor repository.

Other

175 stars 87 forks source link

resolves #19 - migrate to Foundation 5 #23

Open mojavelinux opened 9 years ago

mojavelinux commented 9 years ago

migrate from Foundation 4 to Foundation 5
upgrade to Compass 1.0.1
make stylesheet changes necessary to accomodate upgrades
add Bower configuration
update README with information about Bower requirement
refactor handling of trailing margins in asciidoc component
drop old themes: iconic, colony, maker, rubygems
rework readthedocs theme to match new theme on readthedocs.org
add motion theme
improve build-stylesheet.sh script
declare custom sass functions
fix background colors for sidebar & example blocks in asciidoctor theme
many minor refinements to styles & scss source

ggrossetie commented 8 years ago

I will do a code review this week-end :smile:

mojavelinux commented 8 years ago

:+1:

ggrossetie commented 8 years ago

https://github.com/Huddle/PhantomCSS is looking great, I will try to setup a simple script to automate visual testing.

SevereOverfl0w commented 7 years ago

I'd be happy to pick up the PhantomCSS testing. Could you give me some pointers on where to put the automated visual testing?

It would be nice to push onto Foundation 6, but there isn't a migration guide that I've seen. I'd be happy to dig in.

I have got asciidoctor to compile with libsass (via node-sass and bower) which means that Ruby can go altogether. This might be something to explore, as libsass is more portable than compass/ruby. I used a compass-mixin library from bower.

ggrossetie commented 7 years ago

Hello @SevereOverfl0w

I'd be happy to pick up the PhantomCSS testing. Could you give me some pointers on where to put the automated visual testing?

I've done some work with PhantomCSS here: https://github.com/asciidoctor/asciidoctor-stylesheet-factory/pull/30 The basic idea was to produce a screenshot of the Asciidoctor User Manual before and after the migration.

During my tests, I've only found one small "regression", so I think it's safe to merge this pull request and work on the next migration (Foundation 5 > Foundation 6). Otherwise we will fall behind quickly :cry: