search

asciidoctor / asciidoctor-stylesheet-factory

!DEPRECATED! This was the utility project for producing the default stylesheet for the HTML converter in Asciidoctor. The source of the default stylesheet now lives in the main Asciidoctor repository.
Other
175 stars 87 forks source link

Replace deprecated compass #35

Open jirutka opened 7 years ago

jirutka commented 7 years ago

From https://github.com/Compass/compass:

Compass is no longer actively maintained.

mojavelinux commented 7 years ago

Honestly, I'm not really worried about fixing this deprecation because I think we really need to rethink this whole repository. If we want to keep building on Foundation, we need to upgrade to Foundation 6, which uses a completely different toolchain.

jirutka commented 7 years ago

I don’t think that Foundation is a good choice for this, it’s quite heavy for designing purely content pages. It’d be IMHO better to write it from scratch and use just some simple styles suite for good typography.

But I agree with rethinking this repository; rewriting it completely to be more specific. I’ve used it as a base for https://github.com/bigclownlabs/bc-doc, but I’m really not happy with sass/components/_asciidoc.scss, it’s hackish and badly parametrized. However, still better than starting with nothing. :)

We should also change (modernize and simplify) HTML structure, but that’s a different story.

mojavelinux commented 7 years ago

I don’t think that Foundation is a good choice for this

I was going to say that next. I tend to agree. Understand that I created this repository this way to get something off the ground. Back then, we had no stylesheet and didn't understand its importance. Now we have a new perspective and need to rethink this whole thing. This will be something I'll be looking at for the project in 2017 for sure.

mojavelinux commented 7 years ago

We should also change (modernize and simplify) HTML structure, but that’s a different story.

That's one of the top items on the roadmap for 2017. We'll have an "html5 semantic" converter that will eventually become the default. In a way, we've already done a lot of the thinking for it in the EPUB3 and Bespoke converters. We're discussing that in https://github.com/asciidoctor/asciidoctor/issues/242. I don't really want to create a new stylesheet until we get that settled first.

jirutka commented 7 years ago

We'll have an "html5 semantic" converter…

I’ve started with that in https://github.com/jirutka/asciidoctor-html5, but never finished it. :/ IIRC the converter templates are almost done, but styles are not (so I don’t know if the structure is good for styling).

jirutka commented 7 years ago

Actually, this is the original reason why I started asciidoctor-doctest. 😸 I need to find some time to finish this effort.

jmini commented 5 years ago

What is the current status on this?

I have tried to run this project. We had/have trouble with the cssshrink that is using * to specify the version of its dependencies.

Also the different sed command in build-stylesheet.sh seems not all to have any effect. It is not easy to understand what is really necessary and what is not. (In addition we have observed sometimes different sed behavior on mac and on linux).

It seems that people are moving from compass to node-saas/LibSass.

Is this also something this project would like to do?

The move to semantic HTML5 seems interesting and https://github.com/jirutka/asciidoctor-html5 seems to be maintained. But is this the future?

What is the recommended way for custom styles for Asciidoctor in 2019.

Thank you in advance for your highlights.

mojavelinux commented 5 years ago

I'll be perfectly honest. This project is for me to make the default stylesheet. There are better ways to make stylesheets for Asciidoctor (such as from scratch) and it's unlikely I'm going to work on this project anymore than I have to.

mojavelinux commented 5 years ago

For a bunch of skins, see https://github.com/darshandsoni/asciidoctor-skins.

mojavelinux commented 5 years ago

As part of working on https://github.com/asciidoctor/asciidoctor/issues/242, we'll add a modern way to make stylesheets that targets that output. I'm just too busy to fix this repository and it's too outdated to make it worth it anyway. Better to start over.

mojavelinux commented 5 years ago

Also the different sed command in build-stylesheet.sh seems not all to have any effect.

Again, that's only for the default stylesheet. You should not otherwise be using that.

mojavelinux commented 5 years ago

Btw, I don't mean to sound short. I'm just way too busy right now and I have to cut back on the amount of things I'm worrying about. I think all mentions of this repository should be taken out of the documentation. It's being sunsetted. We will have something better, but I'm not ready to start on it yet until I deal with other concerns first.

jmini commented 5 years ago

Your feedback is already great! Thank you for the update.

Nobody is blaming you or asciidoctor.

mojavelinux commented 5 years ago

Thanks Jérémie!

I'll make sure to post a notice in the README with some pointers as to where else to look. Thanks for your patience!