search

asciidoctor / asciidoctor-stylesheet-factory

!DEPRECATED! This was the utility project for producing the default stylesheet for the HTML converter in Asciidoctor. The source of the default stylesheet now lives in the main Asciidoctor repository.
Other
175 stars 87 forks source link

summary element not rendered properly on FireFox #40

Closed Foadsf closed 4 years ago

Foadsf commented 5 years ago

I was instructed here by @Mogztter to open a new issue here. I will just quote him:

It's a style issue on Firefox (not related to this extension). Asciidoctor default stylesheet is using Foundation 4.3.2 and Foundation is using Normalize 2.1.2 which wrongly uses a display: block on summary element. The correct display should be display: list-item. This issue is already fixed in the latest normalize release: https://github.com/necolas/normalize.css/blob/master/normalize.css#L329

basically I want to have collapsible sections as demonstrated here. However the black arrow next to the collapsible link is not shown:

hlDKvRJQwv

it should be like:

r3cO5RcGaT

surprisingly on Atom I have the exact opposite issue. The arrow is rendered but the collapsible part is not collapsible :)

PGMRHtNYUx

mojavelinux commented 5 years ago

Ah, this must be caused by normalize.css. I bet it is clearing away the browser styles.

Foadsf commented 5 years ago

@mojavelinux it sure does:

firefox_AO5BQFZdgh

In fact that's the main issue with the browser option as I have indicated here. If this is the reason why syntax highlighting not working properly, then this issue will also be solved.

mojavelinux commented 5 years ago

If this is the reason why syntax highlighting not working properly, then this issue will also be solved.

Let's not mix issues. This issue has nothing to do with syntax highlighting. We'll focus on getting the details/summary working.

Foadsf commented 5 years ago

Let's not mix issues. This issue has nothing to do with syntax highlighting.

@mojavelinux oh sorry, Then I have misunderstood your first point.

We'll focus on getting the details/summary working.

great. Thanks for your kind support.

mojavelinux commented 5 years ago

No problem. I followed up in the other issue about the syntax highlighting.

mojavelinux commented 4 years ago

This was resolved by 3c32edaed52f26e54944b43184ee3e501e3b10c3.