Closed cmoulliard closed 3 years ago
I'm not comfortable with having a style named "redhat" in the repository as that is a strongly protected brand. However, I am very glad that you raised the issue about the Liberation Sans fonts. Given that Asciidoctor is strongly rooted in the open source culture, I think it's a very good idea to use open source fonts in the default Asciidoctor stylesheet. I've opened an issue and scheduled it for 1.5.1. See https://github.com/asciidoctor/asciidoctor/issues/879
Naturally, we need to have a simpler way to locate and integrate custom themes in Asciidoctor. We'll get it done as soon as we can.
We can rename the stylesheet to avoid that RedHat name appears. Suggestion - 'liberation' or 'liberation-sans' ?
liberation sounds great to me!
Will prepare a new PR with modification + also font-size change as the existing font is too small for paragraph rendering compared to asciidoctor stylesheet
On Wed, Jan 29, 2014 at 12:51 PM, Dan Allen notifications@github.comwrote:
liberation sounds great to me!
Reply to this email directly or view it on GitHubhttps://github.com/asciidoctor/asciidoctor-stylesheet-factory/pull/7#issuecomment-33578025 .
Charles Moulliard Apache Committer / Architect @RedHat Twitter : @cmoulliard | Blog : http://cmoulliard.github.io
Modify the PR according to our discussion (rename redhat to liberation)
@include font-face("liberation Sans Regular", inline-font-files("liberation/Sans-Regular.ttf", "liberation/Sans-Regular.eot", "liberation/Sans-Regular.svg","liberation/Sans-Regular.woff"));