search

asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
328 stars 97 forks source link

diagram (specifically plantUML) support in asciidoctorjs #105

Closed shivakumargn closed 5 years ago

shivakumargn commented 6 years ago

Thanks for the awesome extension.

Is it possible to support diagram extensions in asciidoctorjs, specifically plantUML. There seems to be support existing already in the upstream. Chrome browser extension works well already.

https://github.com/asciidoctor/asciidoctor-browser-extension/issues/79 https://yarnpkg.com/en/package/asciidoctor-plantuml https://github.com/eshepelyuk/asciidoctor-plantuml.js

joaompinto commented 5 years ago

We currently have graphviz support:

[graphviz] .... graph { a -- b; b -- c; a -- c; d -- c; e -- c; e -- a; } ....

Regarding plantuml I will need to do some research on node-plantuml .

joaompinto commented 5 years ago

Testing it with https://github.com/eshepelyuk/asciidoctor-plantuml.js .

joaompinto commented 5 years ago

UML support on the asciidoctor_js was added on 2.1.0, take a look at https://raw.githubusercontent.com/asciidoctor/asciidoctor-vscode/master/test/samples/plantuml.adoc .

I am closing the issue assuming that you can know use the asciidoctor js without any issues, if there is something else that are you are missing with asciidoctor js please open a new issue.

Thank you for your patience.

forest-yang commented 5 years ago

It works on Chrome with extension, but still does not work with VSCode.

Version: OS: macOS Mojave 10.14.4 VSCode: 1.33.1 AsciiDoc extension: 2.5.2