search

asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
337 stars 97 forks source link

Add additional logs when generating a PDF #205

Open DennisL68 opened 5 years ago

DennisL68 commented 5 years ago

Description

Enabling asciidoc.trace doesn't seem to produce a trace file on Windows

System Information

Version: 1.34.0 (user setup) OS: Windows_NT x64 6.1.7601 AsciiDoc: 2.7.6

To Reproduce

Steps to reproduce the issue:

  1. Find asciidoc trace in Settings
  2. Change variable to verbose
  3. Do some action like producing a PDF using wkhtmltopdf
  4. Look for trace files ending in .log created during the time interval

Screenshots & Files

N/A

Additional Context

I'm trying to get the file paths for images sent to wkhtmltopdf that isn't rendered.

DennisL68 commented 5 years ago

Any takings on this? Surely, a trace file should be generated when setting asciidoc trace to verbose?

CWempe commented 3 years ago

Same here.

Windows 10 VScode v1.56.2 AsciiDoc-Extension v2.8.9 Using asciidoc-pdf to create PDF.

I think it would be even better if the output would be displayed in VScode somewhere. With the option to highlight Errors in the correct line of the code.

Especially with erros like:

asciidoctor: ERROR: could not locate or load the built-in pdf theme `theme/this_themedoes_not_exist.yml'; reverting to default theme

It looks like VScode created the PDF correctly, but then you wonder why the theme was not applied. 😢

But for a start it would be enough to have a log file.

ggrossetie commented 3 years ago

We make very little use of the logger when converting to PDF using wkhtmltopdf:

https://github.com/asciidoctor/asciidoctor-vscode/blob/8d7c8b8fbed0b826705daadbd4592481d2e808d7/src/commands/exportAsPDF.ts#L166

That's probably why no log is generated.